typescript(vx-glyph): re-write package in TypeScript #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Sep 24, 2019
| size?: number | ((d: Datum) => number); | ||
| }; | ||
|
|
||
| export default function GlyphCircle<Datum = any>({ |
There was a problem hiding this comment.
the Datum generic here is not useful unless the consumer leverages the children override. but since d3s symbol takes it as an arg I think exposing it is good.
williaster
force-pushed
the
chris--typescript-vx-glyph
branch
from
454ba59
to
96afc64
Compare
williaster
force-pushed
the
chris--typescript-vx-glyph
branch
from
96afc64
to
8966fea
Compare
added 7 commits
December 18, 2019 11:43
williaster
force-pushed
the
chris--typescript-vx-glyph
branch
from
a50bc49
to
0bc1d0a
Compare
|
build passed but can't fix/ignore the fossa issue, I think it's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off #488 which introduces Typescript build config, and re-writes the
@vx/glyphpackage in TypeScript.Closes #516.
💥 Breaking Changes
React.Fragments, which requires bumping thepeerDepforreactto^16.3.0-0childrenprop fromGlyphDotcomponentTests
/legends+/glyphsdemos (did not actually update/glyphsdemo).d.tsfiles@hshoff @schillerk @milesj @kristw @Rudeg