typescript(vx-mock-data): re-write packge in TypeScript #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
approved these changes
Oct 28, 2019
| width, | ||
| height, | ||
| }: GenPhyllotaxis): GenPhyllotaxisFunction { | ||
| const theta = Math.PI * (3 - Math.sqrt(5)); |
There was a problem hiding this comment.
could pull this out of genPhyllotaxis
| @@ -1,4 +1,10 @@ | |||
| export default [ | |||
| export interface Exoplanets { | |||
There was a problem hiding this comment.
whoa missed that we had this one 👨🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off #488 which introduces Typescript build config, and re-writes the
@vx/mock-datapackage in TypeScriptCloses #548
Tests
.d.tsfiles@williaster @kristw