typescript(vx-axis): re-write package in TypeScript #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 27, 2019 10:16
williaster
commented
Dec 29, 2019
williaster
commented
Dec 29, 2019
|
|
||
| const horizontal = orientation !== ORIENT.left && orientation !== ORIENT.right; | ||
| const isLeft = orientation === ORIENT.left; | ||
| const isTop = orientation === ORIENT.top; | ||
| const tickSign = isLeft || isTop ? -1 : 1; | ||
|
|
||
| const position = (scale.bandwidth ? center : identity)(scale.copy()); |
There was a problem hiding this comment.
center handles scales without a bandwidth method
williaster
commented
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃殌 Enhancements
This PR builds off #488 which introduces Typescript build config, and re-writes the
@vx/axispackage in TypeScript, closing #564.The trickiest part of this (like
@vx/legend) is supporting alld3scale types. In #551 I tried using a union of actuald3-scaletypes, but as noted there this is challenging because thedomain/rangegenerics for different scales have different levels of strictness. So In this PR I tried writing aGenericScale<ScaleInput>type, whereScaleOutputmust be coercible to a number (for plotting on an axis) and wrote tests to ensure it's compatible with each type of scale exported from@vx/scale.Tests
@vx/scale/axisdemos.d.tsfilescc @hshoff @schillerk @kristw @Rudeg