appsecret_proof for server API calls #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an make server API calls securely
…solve that. Then, do some variable renaming for clarity
hsinhoyeh
reviewed
Jun 1, 2017
accountKit.go
Outdated
| @@ -42,9 +45,13 @@ func NewAccountKit(appID, appSecret string) *AccountKit { | |||
| } | |||
| } | |||
|
|
|||
| func (a *AccountKit) VerifyByToken(token string) (*Profile, error) { | |||
| func (a *AccountKit) VerifyByToken(userAccessToken string, accountKitAppSecret string) (*Profile, error) { | |||
There was a problem hiding this comment.
thanks for submitting pr.
just one quick question: what is difference between this accountKitAppSecret and the one existing AppSecret?
There was a problem hiding this comment.
@hsinhoyeh yes, you are right. We do not need to pass in the accountKitAppSecret again, it can already be retrieved via a.AppSecret. Resolved.
|
@hsinhoyeh all good to go with this PR? Cheers, |
|
looks good, I am going to merge it, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement hmac sha256 function to create appsecret_proof so that we can make server API calls securely