Merge pull request #118 from leaphub/update-security-config

Add missing security configuration params
hslavich · Aug 13, 2020 · cef2818 · cef2818
2 parents 36b5f1b + ad3637f
commit cef2818
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -120,6 +120,11 @@ public function getConfigTreeBuilder()
                         ->end()
                         ->booleanNode('signMetadata')->end()
                         ->booleanNode('wantXMLValidation')->end()
+                        ->booleanNode('relaxDestinationValidation')->end()
+                        ->booleanNode('destinationStrictlyMatches')
+                            ->defaultTrue()
+                        ->end()
+                        ->booleanNode('rejectUnsolicitedResponsesWithInResponseTo')->end()
                         ->booleanNode('lowercaseUrlencoding')->end()
                         ->scalarNode('signatureAlgorithm')->end()
                         ->scalarNode('digestAlgorithm')->end()

diff --git a/Tests/DependencyInjection/Fixtures/full.yaml b/Tests/DependencyInjection/Fixtures/full.yaml
@@ -38,6 +38,9 @@ hslavich_onelogin_saml:
         requestedAuthnContext: true
         signMetadata: false
         wantXMLValidation: false
+        relaxDestinationValidation: false
+        destinationStrictlyMatches: true
+        rejectUnsolicitedResponsesWithInResponseTo: false
         signatureAlgorithm: 'http://www.w3.org/2000/09/xmldsig#rsa-sha1'
     contactPerson:
         technical:

diff --git a/Tests/DependencyInjection/HslavichOneloginSamlExtensionTest.php b/Tests/DependencyInjection/HslavichOneloginSamlExtensionTest.php
@@ -57,6 +57,9 @@ public function testLoadSecuritySettings()
         $this->assertTrue($settings['security']['requestedAuthnContext']);
         $this->assertFalse($settings['security']['signMetadata']);
         $this->assertFalse($settings['security']['wantXMLValidation']);
+        $this->assertFalse($settings['security']['relaxDestinationValidation']);
+        $this->assertTrue($settings['security']['destinationStrictlyMatches']);
+        $this->assertFalse($settings['security']['rejectUnsolicitedResponsesWithInResponseTo']);
         $this->assertEquals('http://www.w3.org/2000/09/xmldsig#rsa-sha1', $settings['security']['signatureAlgorithm']);
     }