Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendlier threaded problem handling #188

Closed
ghost opened this issue Jun 22, 2013 · 3 comments
Closed

Friendlier threaded problem handling #188

ghost opened this issue Jun 22, 2013 · 3 comments
Labels
enhancement Feature requests and enhancements.

Comments

@ghost
Copy link

ghost commented Jun 22, 2013

Problems in threads like the ones happening in ME's remove_dead_tracks could be better handled than by simply throwing a crash report. The problem however is to modify jobprogress's capabilities to allow for some kind of return value in job_completed() to allow for, for example, a call to show_message() or something, a call that cannot happen in the async function.

@ghost ghost mentioned this issue Jun 22, 2013
@ghost ghost closed this as completed Jun 22, 2013
@ghost
Copy link
Author

ghost commented Jun 22, 2013

In the process of implementing this, I uncovered a bug which I filed at #196.

@ghost
Copy link
Author

ghost commented Jun 22, 2013

(from [f75db44f5c07]) [#196 state:fixed] [#188] Fixed a crash on crash reporting under Cocoa and improved job management to allow threaded error handling on _job_finished().
https://bitbucket.org/hsoft/dupeguru/changeset/f75db44f5c07/

@ghost
Copy link
Author

ghost commented Jun 22, 2013

(from [d99996484950]) [#188 state:fixed] Instead of showing a crash report on iTunes communication problems, show a friendlier message.
https://bitbucket.org/hsoft/dupeguru/changeset/d99996484950/

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and enhancements.
Projects
None yet
Development

No branches or pull requests

0 participants