Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak "Make selected reference" #222

Closed
ghost opened this issue Jun 22, 2013 · 6 comments
Closed

Tweak "Make selected reference" #222

ghost opened this issue Jun 22, 2013 · 6 comments
Labels
enhancement Feature requests and enhancements.

Comments

@ghost
Copy link

ghost commented Jun 22, 2013

from email:

Once I've visually isolated a group, then I need to mark the ones to delete. The first time I did this, the file I wanted to delete was the first one in the group and I couldn't delete it. I was unable to figure what to do from the program and it took me about half an hour to find the relevant part of the manual. Once I found it, I figured out why it took me so long. I interpreted the context menu item "make selected reference" to mean something completely different than it does. This was because I parsed the phrase differently. I didn't read it as "Take the selected item and make it the reference item". I read it as "make something into a selected reference". Since that didn't make sense, I ignored it.

If you could rename this menu item to something like "make selected into reference" or something like that, it might keep others from having the same confusion I did.

Good idea. Confusion about this feature is a recurring support question.

Another one in the same vein:

When I use that context menu item, it takes the selected item, swaps it with the reference item, then leaves the newly swapped used-to-be-reference item highlighted. I found this very confusing. I'm used to programs that keep the highlight on the same semantic item, not the item in the same relative position after an operation. (This probably contributed to me not figuring out how to use that menu item. My directory names are very similar and the file names mostly identical. When experimenting and I selected that menu item, I probably thought it didn't actually do anything.)

Good idea too.

@ghost ghost closed this as completed Jun 22, 2013
@ghost
Copy link
Author

ghost commented Jun 22, 2013

(from [5e2e1d829be2]) [#222] Tweaked ref-swapping action text.

Make Selected Reference --> Make Selected into Reference.
https://bitbucket.org/hsoft/dupeguru/changeset/5e2e1d829be2/

@ghost
Copy link
Author

ghost commented Jun 22, 2013

(from [5a74b369373d]) [#222] Tweaked dupe selection after a ref-swapping action.
https://bitbucket.org/hsoft/dupeguru/changeset/5a74b369373d/

@ghost
Copy link
Author

ghost commented Jun 22, 2013

Ticket fixed, but testing on OS X is needed.

@ghost
Copy link
Author

ghost commented Jun 22, 2013

(from [1d1351a0c3f7]) Tweaked Make Selected into Reference.

Having dupes from ref folders (which makes ref switching impossible) would make
the new feature glitchy (selection would be emptied). Now, in cases where the action
results in nothing being changed, the selection stays intact. [#222]
https://bitbucket.org/hsoft/dupeguru/changeset/1d1351a0c3f7/

@ghost
Copy link
Author

ghost commented Jun 22, 2013

Tested on OS X. Ticket fixed.

@ghost
Copy link
Author

ghost commented Jun 22, 2013

(from [810ab1e1324e]) Improved selection handling during ref-swapping under dupes-only mode.

Previously, our selection would simply be lost (because the dupes that were
just swapped wouldn't be present in the table). Now, instead of trying to
preserve our dupe-selection, we preserve our index-selection when in dupes-only
mode. [#222]
https://bitbucket.org/hsoft/dupeguru/changeset/810ab1e1324e/

emmanuelgautier1994 pushed a commit to entrepreneur-interet-general/ESOTIM that referenced this issue Mar 12, 2018
Make Selected Reference --> Make Selected into Reference.
emmanuelgautier1994 pushed a commit to entrepreneur-interet-general/ESOTIM that referenced this issue Mar 12, 2018
emmanuelgautier1994 pushed a commit to entrepreneur-interet-general/ESOTIM that referenced this issue Mar 12, 2018
Having dupes from ref folders (which makes ref switching impossible) would make
the new feature glitchy (selection would be emptied). Now, in cases where the action
results in nothing being changed, the selection stays intact. [arsenetar#222]
emmanuelgautier1994 pushed a commit to entrepreneur-interet-general/ESOTIM that referenced this issue Mar 12, 2018
Previously, our selection would simply be lost (because the dupes that were
just swapped wouldn't be present in the table). Now, instead of trying to
preserve our dupe-selection, we preserve our index-selection when in dupes-only
mode. [arsenetar#222]
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and enhancements.
Projects
None yet
Development

No branches or pull requests

0 participants