Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix wrong server version for the result of hstream node status c… #1631

Merged
merged 4 commits into from Oct 10, 2023
Merged

cli: fix wrong server version for the result of hstream node status c… #1631

merged 4 commits into from Oct 10, 2023

Conversation

YangKian
Copy link
Contributor

@YangKian YangKian commented Oct 8, 2023

…ommand

PR Description

Type of change

  • Bug fix

Checklist

  • I have run format.sh under script
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

4eUeP
4eUeP reviewed Oct 10, 2023
View reviewed changes
common/hstream/HStream/Common/Types.hs Outdated Show resolved Hide resolved
common/hstream/HStream/Common/Types.hs Outdated Show resolved Hide resolved
common/hstream/HStream/Common/Types.hs Outdated Show resolved Hide resolved
hstream/app/server.hs Outdated Show resolved Hide resolved
hstream/app/server.hs Outdated Show resolved Hide resolved
common/hstream/test/HStream/ConsistentHashingSpec.hs Outdated Show resolved Hide resolved
@4eUeP 4eUeP merged commit 980c9ca into hstreamdb:main Oct 10, 2023
7 checks passed
@YangKian YangKian deleted the check branch October 10, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4eUeP 4eUeP 4eUeP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YangKian @4eUeP