Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka: add handler-level metrics for cpp server #1815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

kafka: add handler-level metrics for cpp server #1815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05bc9df
kafka: add handler-level metrics for cpp server
YangKian May 10, 2024
ed91422
Merge branch 'main' into metrics
YangKian May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions hstream-kafka/HStream/Kafka/Network.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ runHsServer opts sc_ mkPreAuthedHandlers mkAuthedHandlers =

doUnaryHandler l reqHeader@RequestHeader{..} rpcHandler' peer = do
(req, left) <- runGet' l
when (not . BS.null $ left) $
unless (BS.null left) $
Log.warning $ "Leftover bytes: " <> Log.buildString' left
Log.debug $ "Received request "
<> Log.buildString' requestApiKey
Expand Down Expand Up @@ -237,10 +237,14 @@ runCppServer opts sc_ mkAuthedHandlers =
(sc, conn) <- deRefStablePtr sptr
let handlers = mkAuthedHandlers sc
req <- peek request_ptr
M.incCounter M.totalRequests
(header, reqBs) <- runGet' @RequestHeader req.requestPayload
let ServiceHandler{..} = findHandler handlers header.requestApiKey header.requestApiVersion
-- respBs: Nothing means some error occurred, and the server will close
-- the connection
respBs <- E.catch
(Just <$> handleKafkaMsg conn handlers req.requestPayload)
(Just <$> M.observeWithLabel M.handlerLatencies (Text.pack $ show header.requestApiKey)
(handleKafkaMsg conn rpcHandler header reqBs))
(\err -> do Log.fatal $ Log.buildString' (err :: E.SomeException)
pure Nothing)
poke response_ptr Cxx.Response{responseData = respBs}
Expand All @@ -250,19 +254,21 @@ runCppServer opts sc_ mkAuthedHandlers =
-- Server misc

handleKafkaMsg
:: Cxx.ConnContext -> [ServiceHandler] -> ByteString -> IO ByteString
handleKafkaMsg conn handlers bs = do
(header, reqBs) <- runGet' @RequestHeader bs
let ServiceHandler{..} = findHandler handlers header.requestApiKey header.requestApiVersion
:: Cxx.ConnContext
-> RpcHandler
-> RequestHeader
-> ByteString
-> IO ByteString
handleKafkaMsg conn rpcHandler header bs = do
case rpcHandler of
UnaryHandler rpcHandler' -> do
(req, left) <- runGet' reqBs
(req, left) <- runGet' bs
Log.debug $ "Received request "
<> Log.buildString' header.requestApiKey
<> ":v" <> Log.build header.requestApiVersion
<> " from " <> Log.buildString' conn.peerHost
<> ", payload: " <> Log.buildString' req
when (not . BS.null $ left) $
unless (BS.null left) $
Log.warning $ "Leftover bytes: " <> Log.buildString' left
let reqContext =
RequestContext
Expand Down
Loading