-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(to_cpp1): improve recognition of dependent types and deducible parameters #533
Open
JohelEGP
wants to merge
1
commit into
hsutter:main
Choose a base branch
from
JohelEGP:optional_typename
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
JohelEGP
changed the title
fix(cpp1): emit
fix(cpp1): emit Jul 4, 2023
typename
in dependent type-only contextstypename
/template
in unambiguous dependent contexts
JohelEGP
commented
Jul 6, 2023
JohelEGP
changed the title
fix(cpp1): emit
fix(cpp1): improve recognition of dependent and deducible parameters
Jul 6, 2023
typename
/template
in unambiguous dependent contexts
JohelEGP
changed the title
fix(cpp1): improve recognition of dependent and deducible parameters
fix(cpp1): improve recognition of dependent types and deducible parameters
Jul 6, 2023
This was referenced Aug 5, 2023
JohelEGP
force-pushed
the
optional_typename
branch
from
August 14, 2023 15:19
ffacee7
to
58ee983
Compare
hsutter
requested changes
Aug 27, 2023
JohelEGP
force-pushed
the
optional_typename
branch
2 times, most recently
from
September 13, 2023 22:10
6262f55
to
c1d257b
Compare
JohelEGP
force-pushed
the
optional_typename
branch
from
September 22, 2023 16:45
c1d257b
to
15b7551
Compare
JohelEGP
force-pushed
the
optional_typename
branch
from
October 3, 2023 18:44
15b7551
to
cb586e6
Compare
JohelEGP
force-pushed
the
optional_typename
branch
from
October 31, 2023 14:34
cb586e6
to
4900c6c
Compare
JohelEGP
commented
Oct 31, 2023
JohelEGP
force-pushed
the
optional_typename
branch
from
November 9, 2023 21:22
b421c19
to
ccb10cf
Compare
JohelEGP
changed the title
fix(cpp1): improve recognition of dependent types and deducible parameters
fix(to_cpp1): improve recognition of dependent types and deducible parameters
Nov 9, 2023
JohelEGP
force-pushed
the
optional_typename
branch
from
November 9, 2023 21:23
ccb10cf
to
780b99a
Compare
JohelEGP
force-pushed
the
optional_typename
branch
from
November 21, 2023 00:36
780b99a
to
ae91505
Compare
JohelEGP
force-pushed
the
optional_typename
branch
from
December 11, 2023 16:01
b9b5592
to
591cd4b
Compare
Patch for merging with #596: diff --git a/source/to_cpp1.h b/source/to_cpp1.h
index 2ece7c3..503cf12 100644
--- a/source/to_cpp1.h
+++ b/source/to_cpp1.h
@@ -2019,6 +2019,12 @@ public:
{
return self->is_dependent(*expr.result_type);
}
+
+ auto operator()(requires_expression_node const&) const
+ -> bool
+ {
+ return false;
+ }
};
auto is_dependent( |
JohelEGP
force-pushed
the
optional_typename
branch
from
December 23, 2023 16:12
d0986ee
to
610c254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #534. Resolves #595.
Resolves #628 (as a discussion, this needs to be manually closed).
Adds what's needed to diagnose #572.
Testing summary:
Acknowledgements: