Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for the build and work with ignore plugin, distinct fold for ignored files #23

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

scanban
Copy link

@scanban scanban commented Jul 31, 2022

Hide ignored files functionality In IDEA 2022.2 "ignore" plugin
was removed and recommended way to have the same functionality is now
to install "Foldable ProjectView" plugin.

Add distinct "folder" for the ignored files, to divide it from the folded
by pattern.

Tested on the latest CLion 2022.2

@jrhorn424
Copy link

May I recommend prioritizing this for review and merge? I ask because it's possible that this change addresses #3, #6, #11, #14, #15, making it a high-value change.

@scanban What are your thoughts?

I am not familiar with Kotlin or with Java. I am fluent in OOP as a long-time Ruby user. I have not read this plugin codebase, only this diff.

That disclaimer out of the way, this looks like the label on the tin matches its contents. 💯

@scanban
Copy link
Author

scanban commented Sep 27, 2022

May I recommend prioritizing this for review and merge? I ask because it's possible that this change addresses #3, #6, #11, #14, #15, making it a high-value change.

@scanban What are your thoughts?

I am not familiar with Kotlin or with Java. I am fluent in OOP as a long-time Ruby user. I have not read this plugin codebase, only this diff.

That disclaimer out of the way, this looks like the label on the tin matches its contents. 💯

@jrhorn424 Sorry for the late reply, overloaded @ work atm ;)
regarding your question - I didn't get any problems from listed issues. I am using plugin with my
modifications on Clion in everyday work.

See jetbrains issue: https://youtrack.jetbrains.com/issue/KTIJ-20816
Bogus error "Cannot inline bytecode built with JVM target 11 into
bytecode that is being built with JVM target 1.8."
Hide ignored files functionality In IDEA 2022.2 "ignore" plugin
was removed and recommended way to have the same functionality is now
to install "Foldable ProjectView" plugin.
The problem is that "ignore" plugin have its own FileStatus
with id = "IGNORE.PROJECT_VIEW.IGNORED"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants