Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning when nested <q> #215

Closed
ghost opened this issue May 23, 2015 · 6 comments
Closed

Remove warning when nested <q> #215

ghost opened this issue May 23, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@ghost
Copy link

ghost commented May 23, 2015

Currently when we nest quotes tidy warns that we could have a typo.

@geoffmcl
Copy link
Contributor

@andya9 to speed things up and save me doing lots of research could you please give a short sample html. Show the config used, the output, and what the expected output should be... thanks...

@ghost
Copy link
Author

ghost commented May 23, 2015

@geoffmcl no problem:
sample: https://gist.github.com/andya9/1730af246fa764da7fd6
output in browser: He said: “You know, they told me: ‘Hey!’; and they ran away”.
tidy output (tidy5 sample.html): line 8 column 10 - Warning: nested q elements, possible typo.
no particular config used, just default

@geoffmcl
Copy link
Contributor

@andya9 thanks for the sample... seems this warning has been in tidy for a LONG time... since before the last release circa 2009... will see what I can do...

@geoffmcl geoffmcl added the Bug label May 23, 2015
@geoffmcl geoffmcl added this to the 5.0.0 milestone May 23, 2015
@geoffmcl geoffmcl self-assigned this May 23, 2015
@ghost
Copy link
Author

ghost commented May 23, 2015

@geoffmcl Thank’you for looking into this!

geoffmcl added a commit that referenced this issue Jun 21, 2015
@geoffmcl
Copy link
Contributor

@andya9 - Hmmm, the message value is NESTED_QUOTATION. Is only used once, in parser.c(1736). Decide to only issue this warning if (TY_(HTMLVersion)(doc) != HT50)

Bumped the version to 4.9.36 for this change.

Hope you get a chance to pull and compile the latest, and close this if fixed... Thanks for reporting...

@ghost
Copy link
Author

ghost commented Jun 21, 2015

@geoffmcl
Just tried it, it works perfectly! Thank’you very much for fixing this!

@ghost ghost closed this as completed Jun 21, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant