-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static linking by default? (on Linux) #326
Comments
Ah, we already have a 4.9 package in there, separately from the old html-tidy. I assume this project is (also) meant as a drop-in replacement for the old html-tidy, including libtidy, right? From a quick skim I only see missing |
@vcunat yes, at this time the tidy console binary is linked with the static library, mainly as a convenience to Windows users where we do not have a convenient DLL (shared library) install mechanism. Easier to have a stand-alone app... And as far as I can see it poses no problem in linux. And in fact, as a developer, it is convenient for me having several stand-alone versions of tidy around for backward testing. But as things settle down we will consider changing this, for linux only, just to conform to the norm... but will continue to build and install both libraries, allowing 3rdParty libtidy or libtidys users a choice... The If you have a 4.9 package there already, I think this will be So, yes, 5.?.? is meant as a drop-in replacement for old tidy, removing that Will leave this open for a while for further comments... if any... but see nothing at present to do here... |
Oh, is there no option to link I plan to replace both versions by unified 5.*. It seems that reverse dependencies build fine, except for prayer-1.3.5 which gets broken: BTW, nix is specifically designed to be able to keep any number of versions and configurations around, even with all its dependency closures (dynamically linked and other references). |
@vcunat ok seems I must read With the beginning of the
Will certainly explore adding a cmake option to link the tidy console app to the shared libray... |
I see; if the headers only got renamed, the breakages will be fixed easily and safely. |
- the original project has been unmaintained for years - some dependants needed to be patched due to renamed headers htacg/tidy-html5#326 (comment) - separate tidy-html5 package was removed, as since the 5.0.0 version it's meant as a successor to both, and library name got back from libtidy5.so to libtidy.so htacg/tidy-html5#326 (comment) /cc committers to tidy-html5: @edwjto and @zimbatm.
@vcunat added a cmake option Have tested all combinations in windows, and all got built/linked as expected. Much appreciated if you could get a chance to pull 5.1.30++ and give it a try... thanks... |
Looks good, except that during build it tries to run the executable and fails to find the library. I worked around that easily, though. The binary is tiny now. |
I've been experimenting with localization and this seems like a good idea as binary size grows significantly with added languages. This would help mitigate that. |
I thought it standard to have the translated texts stored in separate per-language files. |
It would be preferable but compiling them in maintains universal architecture support without having to consider the platform specifics of every operating system in existence. |
I wouldn't expect such a small project to program this from scratch. There are standard frameworks for handling translations in a cross-platform way. |
With the Cmake fix and the discussion going off topic, I'll tidy up and close this issue. |
(Suggested label: Build/Install/Distribute)
Currently when I build it,
bin/tidy
is statically linked, and bothlib/libtidy.so
andlib/libtidys.a
are installed. I believe it would be better to default to dynamic linking and not installing*.a
, at least on unix-like platforms.Side note: I'm creating a package for Nix / NixOS.
The text was updated successfully, but these errors were encountered: