Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary semicolons from includes in example. #242

Merged
merged 2 commits into from Aug 27, 2015

Conversation

b4hand
Copy link
Contributor

@b4hand b4hand commented Aug 25, 2015

These semicolons are almost certainly harmless, but they are not idiomatic in C.

None of the real code appears to follow this convention of having semicolons after each #include, so it seemed strange for them to be included in the example code.

@geoffmcl
Copy link
Contributor

@b4hand agree... good catch, and thanks...

Could I ask you do one more thing before I merge this PR, and that is to change the header name from <buffio.h> to the new correct name <tidybuffio.h> in the first example as it has already been done in the 2nd...

Of course there is the question why we have this example file twice, and several other files... I think we intended to drop the build/documentation folder in favor of the documentation folder, or something...

But I note that the build/documentation/README.md has lots more information than its counterpart, so some information should be moved before such a deletion...

And the CMakeLists.txt still refers to build/documentation/tidy1.xsl which is slightly different to its counterpart... will check these later...

If you could just add that header name change will merge the results... thanks...

@geoffmcl geoffmcl added the Docs label Aug 26, 2015
@geoffmcl geoffmcl added this to the 5.1 milestone Aug 26, 2015
@b4hand
Copy link
Contributor Author

b4hand commented Aug 26, 2015

As requested, it now says #include <tidybuffio.h>.

geoffmcl added a commit that referenced this pull request Aug 27, 2015
Drop unnecessary semicolons from includes in example.
@geoffmcl geoffmcl merged commit 2cfae04 into htacg:master Aug 27, 2015
@geoffmcl
Copy link
Contributor

@b4hand now merged into master, and thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants