Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nav styles to be a little harder to override #2

Merged
merged 2 commits into from
Mar 15, 2014

Conversation

andrewmartin
Copy link
Contributor

Love this template, thanks so much.

I found that adding these two rules prevented any major / strange style overrides.

A basic <header> background color or displaying nav > li as inline (two things I had in a really basic stylesheet were too easy to override the styleguide template styles. This should help.

- noticed theme can override header color
- found this reset to be a bit too easy
@htanjo
Copy link
Owner

htanjo commented Mar 15, 2014

Thank you for reporting.
I'm planning to merge your pull request.

But currently this template isn't compatible with Type Selectors, e.g. h1 { background: red }.
For supporting type selectors, we need to update radically.

@andrewmartin
Copy link
Contributor Author

Can you elaborate? Is this a node-kss limitation?

One problem I had with it that I wanted to mention and suggest is this:

When using a vendor library, like Twitter Bootstrap, the styles tend to get really messed up. Am wondering if this theme (or another one created) should use that bootstrap class system in order to maintain style structure. How do you think this problem could be solved?

On Friday, March 14, 2014 at 9:27 PM, Tanjo, Hiroyuki wrote:

Thank you for reporting.
I'm planning to merge your pull request.
But currently this template isn't compatible with Type Selectors, e.g. h1 { background: red }.
For supporting type selectors, we need to update radically.


Reply to this email directly or view it on GitHub (#2 (comment)).

@htanjo
Copy link
Owner

htanjo commented Mar 15, 2014

The incompatibility is an issue of my theme. And it is related to the design of kss-node.
kss-node generates a single html including both user's css and doc theme css.

I think styledocco doesn't have such a problem because that uses <iframe> for the preview content.

I want to achieve below,

  1. Theme css never affect on the markup preview area.
  2. Layout of the document can't be disturbed by any user css.

I believe 1 is already done. And 2 is hard to achieve completely.
I will apply more detailed properties to the doc and navigation areas to support 2.
Your pull request helps it.

Thanks.

htanjo added a commit that referenced this pull request Mar 15, 2014
Update nav styles to be a little harder to override
@htanjo htanjo merged commit 76d552d into htanjo:master Mar 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants