Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new JobRouter syntax (HTCONDOR-243) #435

Merged
merged 10 commits into from Mar 29, 2021

Conversation

brianhlin
Copy link
Collaborator

@brianhlin brianhlin requested a review from johnkn March 16, 2021 21:15
Copy link
Contributor

@matyasselmeci matyasselmeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but overall fine; pre-approving.

config/01-ce-router-defaults.conf.in Outdated Show resolved Hide resolved
src/condor_ce_router_defaults Outdated Show resolved Hide resolved
src/condor_ce_router_defaults Show resolved Hide resolved
@brianhlin
Copy link
Collaborator Author

@johnkn fixed in this commit 7993b98. FWIW, though, we set ROUTED_JOB_MAX_TIME in the same file that we're adding this config, which the admin would have to root around to find, and if they muck with the file there's a good chance that they just break the CE completely. Another pair of suspenders never hurts, though!

@brianhlin
Copy link
Collaborator Author

@johnkn @matyasselmeci is there anything else? I believe the CI failures as of late are unrelated to these changes (osg-test needs to be updated and EL7 UW build tests were failing because of the blahp repo issue last Friday)

@matyasselmeci
Copy link
Contributor

Nothing from me.

@brianhlin
Copy link
Collaborator Author

Overriding osg-test failures as it requires updates to osg-test

@brianhlin brianhlin merged commit 8bca412 into htcondor:V5-branch Mar 29, 2021
@brianhlin brianhlin deleted the HTCONDOR-243.new-jr-syntax branch March 29, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants