Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTCONDOR-2065 Set CURL options for X509 CERT #1743

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

benoitroland
Copy link

PR Description

  • Set CURL options for X509 certificates in the multifile curl plugin.
  • Tested successfully when transferring the output of an HTCondor job to a storage resource checking for X509 certificates.

HTCondor Pull Request Checklist for internal reviewers

  • Verify that (GitHub thinks) the merge is clean. If it isn't, and you're confident you can resolve the conflicts, do so. Otherwise, send it back to the original developer.
  • Verify that the related Jira ticket exists and has a target version number and that it is correct.
  • Verify that the Jira ticket is in review status and is assigned to the reviewer.
  • Verify that the Jira ticket (HTCONDOR-xxx) is mentioned at the beginning of the title. Edit it, if not
  • Verify that the branch destination of the PR matches the target version of the ticket
  • Check for correctness of change
  • Check for regression test(s) of new features and bugfixes (if the feature doesn't require root)
  • Check for documentation, if needed (documentation build logs)
  • Check for version history, if needed
  • Check BaTLab dashboard for successful build (https://batlab.chtc.wisc.edu/results/workspace.php) and test for either the PR or a workspace build by the developer that has the Jira ticket as a comment.
  • Check that each commit message references the Jira ticket (HTCONDOR-xxx)

After the above

  • Hit the merge button if the pull request is approved and it is not a security patch (security changes require 2 additional reviews)
  • If the pull request is approved, take the ticket out of review state
  • Assign JIRA Ticket back to the developer

@benoitroland
Copy link
Author

Dear all,

I have slightly modified the "multifile curl plugin" to set up CURL options for X509 certificates.
The change in .gitignore can of course be ignored.
Thanks a lot for your help!

Cheers,
Benoit

@timtheisen timtheisen added the build-and-test Trigger an automatic Batlab build and test label Sep 5, 2023
@benoitroland
Copy link
Author

Dear Jaime,

I am sorry to annoy you.

Would you have some feedback about the review of this pull request?

Thanks a lot in advance for your help!

@JaimeFrey JaimeFrey changed the title Set CURL options for X509 CERT HTCONDOR-2065 Set CURL options for X509 CERT Oct 3, 2023
@JaimeFrey
Copy link
Member

Sorry for the delayed response. This change looks good.

Copy link
Member

@JaimeFrey JaimeFrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good.

@JaimeFrey JaimeFrey merged commit d7dea33 into htcondor:main Oct 3, 2023
1 check passed
@benoitroland
Copy link
Author

Thanks a lot Jaime!
Cheers,
Benoit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-and-test Trigger an automatic Batlab build and test
Projects
None yet
3 participants