Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTCONDOR-2343 shadow exception msg #2299

Merged
merged 3 commits into from Mar 15, 2024

Conversation

JaimeFrey
Copy link
Member

@JaimeFrey JaimeFrey commented Mar 13, 2024

<Insert PR description here, and leave checklist below for code review.>

HTCondor Pull Request Checklist for internal reviewers

  • Verify that (GitHub thinks) the merge is clean. If it isn't, and you're confident you can resolve the conflicts, do so. Otherwise, send it back to the original developer.
  • Verify that the related Jira ticket exists and has a target version number and that it is correct.
  • Verify that the Jira ticket is in review status and is assigned to the reviewer.
  • Verify that the Jira ticket (HTCONDOR-xxx) is mentioned at the beginning of the title. Edit it, if not
  • Verify that the branch destination of the PR matches the target version of the ticket
  • Check for correctness of change
  • Check for regression test(s) of new features and bugfixes (if the feature doesn't require root)
  • Check for documentation, if needed (documentation build logs)
  • Check for version history, if needed
  • Check BaTLab dashboard for successful build (https://batlab.chtc.wisc.edu/results/workspace.php) and test for either the PR or a workspace build by the developer that has the Jira ticket as a comment.
  • Check that each commit message references the Jira ticket (HTCONDOR-xxx)

After the above

  • Hit the merge button if the pull request is approved and it is not a security patch (security changes require 2 additional reviews)
  • If the pull request is approved, take the ticket out of review state
  • Assign JIRA Ticket back to the developer

A newline in the shadow exception event message breaks the format, so
readers can't parse the event. Convert any newlines to '|'.
@Todd-L-Miller
Copy link
Member

Once could probably write a test for this without too much trouble.

@JaimeFrey JaimeFrey merged commit 4c2bc4b into V23_0-branch Mar 15, 2024
1 check passed
@JaimeFrey JaimeFrey deleted the V23_0-HTCONDOR-2343-shadow-exception-msg branch March 15, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants