Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HTCONDOR-2227) Implement RemoteParm #2348

Merged
merged 10 commits into from Apr 1, 2024
Merged

Conversation

Todd-L-Miller
Copy link
Member

@Todd-L-Miller Todd-L-Miller commented Mar 27, 2024

<Insert PR description here, and leave checklist below for code review.>

HTCondor Pull Request Checklist for internal reviewers

  • Verify that (GitHub thinks) the merge is clean. If it isn't, and you're confident you can resolve the conflicts, do so. Otherwise, send it back to the original developer.
  • Verify that the related Jira ticket exists and has a target version number and that it is correct.
  • Verify that the Jira ticket is in review status and is assigned to the reviewer.
  • Verify that the Jira ticket (HTCONDOR-xxx) is mentioned at the beginning of the title. Edit it, if not
  • Verify that the branch destination of the PR matches the target version of the ticket
  • Check for correctness of change
  • Check for regression test(s) of new features and bugfixes (if the feature doesn't require root)
  • Check for documentation, if needed (documentation build logs)
  • Check for version history, if needed
  • Check BaTLab dashboard for successful build (https://batlab.chtc.wisc.edu/results/workspace.php) and test for either the PR or a workspace build by the developer that has the Jira ticket as a comment.
  • Check that each commit message references the Jira ticket (HTCONDOR-xxx)

After the above

  • Hit the merge button if the pull request is approved and it is not a security patch (security changes require 2 additional reviews)
  • If the pull request is approved, take the ticket out of review state
  • Assign JIRA Ticket back to the developer

@Todd-L-Miller
Copy link
Member Author

Todd-L-Miller commented Mar 27, 2024

Use this link to see the change without the duplicate changes from the merge:

@Todd-L-Miller Todd-L-Miller added the build-and-test Trigger an automatic Batlab build and test label Mar 27, 2024
@Todd-L-Miller
Copy link
Member Author

Todd-L-Miller commented Mar 27, 2024

I've decided to document the silliness of the version 1 API rather than try to change/improve it for now.

@ColeBollig ColeBollig marked this pull request as ready for review March 29, 2024 13:14
@ColeBollig ColeBollig added build-and-test Trigger an automatic Batlab build and test and removed build-and-test Trigger an automatic Batlab build and test labels Apr 1, 2024
Copy link
Contributor

@ColeBollig ColeBollig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Todd-L-Miller Todd-L-Miller merged commit dd4a5cb into main Apr 1, 2024
1 check passed
@Todd-L-Miller Todd-L-Miller deleted the V23_7-HTCONDOR-2227-branch branch April 1, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-and-test Trigger an automatic Batlab build and test
Projects
None yet
2 participants