Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTCONDOR-2443 Implement the AUTO value of ENABLE_STARTD_DAEMON_AD #2464

Merged
merged 2 commits into from
May 16, 2024

Conversation

johnkn
Copy link
Contributor

@johnkn johnkn commented May 14, 2024

The DCCollector object will now do a version check of the collector and refuse
to send StartD daemon ads to collectors where the version is unknown or
less than 23.2 unless ENABLE_STARTD_DAEMON_AD is set to TRUE

<Insert PR description here, and leave checklist below for code review.>

HTCondor Pull Request Checklist for internal reviewers

  • Verify that (GitHub thinks) the merge is clean. If it isn't, and you're confident you can resolve the conflicts, do so. Otherwise, send it back to the original developer.
  • Verify that the related Jira ticket exists and has a target version number and that it is correct.
  • Verify that the Jira ticket is in review status and is assigned to the reviewer.
  • Verify that the Jira ticket (HTCONDOR-xxx) is mentioned at the beginning of the title. Edit it, if not
  • Verify that the branch destination of the PR matches the target version of the ticket
  • Check for correctness of change
  • Check for regression test(s) of new features and bugfixes (if the feature doesn't require root)
  • Check for documentation, if needed (documentation build logs)
  • Check for version history, if needed
  • Check BaTLab dashboard for successful build (https://batlab.chtc.wisc.edu/results/workspace.php) and test for either the PR or a workspace build by the developer that has the Jira ticket as a comment.
  • Check that each commit message references the Jira ticket (HTCONDOR-xxx)

After the above

  • Hit the merge button if the pull request is approved and it is not a security patch (security changes require 2 additional reviews)
  • If the pull request is approved, take the ticket out of review state
  • Assign JIRA Ticket back to the developer

  The DCCollector object will now do a version check of the collector and refuse
  to send StartD daemon ads to collectors where the version is unknown or
  less than 23.2 unless ENABLE_STARTD_DAEMON_AD is set to TRUE
@johnkn johnkn requested a review from JaimeFrey May 14, 2024 16:01
@johnkn johnkn requested review from ColeBollig and removed request for JaimeFrey May 15, 2024 17:09
Copy link
Contributor

@ColeBollig ColeBollig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note: No version history/documentation due to full feature being in development and hand tested due to difficultly to automate

@ColeBollig ColeBollig merged commit d17f779 into main May 16, 2024
1 check passed
@ColeBollig ColeBollig deleted the HTCONDOR-2443-branch branch May 16, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants