Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HTCONDOR-2153) issue_credentials() #2465

Merged
merged 12 commits into from
May 20, 2024

Conversation

Todd-L-Miller
Copy link
Member

@Todd-L-Miller Todd-L-Miller commented May 14, 2024

Hook condor_submit's credential handling into the Python bindings.

HTCondor Pull Request Checklist for internal reviewers

  • Verify that (GitHub thinks) the merge is clean. If it isn't, and you're confident you can resolve the conflicts, do so. Otherwise, send it back to the original developer.
  • Verify that the related Jira ticket exists and has a target version number and that it is correct.
  • Verify that the Jira ticket is in review status and is assigned to the reviewer.
  • Verify that the Jira ticket (HTCONDOR-xxx) is mentioned at the beginning of the title. Edit it, if not
  • Verify that the branch destination of the PR matches the target version of the ticket
  • Check for correctness of change
  • Check for regression test(s) of new features and bugfixes (if the feature doesn't require root)
  • Check for documentation, if needed (documentation build logs)
  • Check for version history, if needed
  • Check BaTLab dashboard for successful build (https://batlab.chtc.wisc.edu/results/workspace.php) and test for either the PR or a workspace build by the developer that has the Jira ticket as a comment.
  • Check that each commit message references the Jira ticket (HTCONDOR-xxx)

After the above

  • Hit the merge button if the pull request is approved and it is not a security patch (security changes require 2 additional reviews)
  • If the pull request is approved, take the ticket out of review state
  • Assign JIRA Ticket back to the developer

@Todd-L-Miller Todd-L-Miller changed the title (HTCONDOR-2153) issue_credentials_for() (HTCONDOR-2153) issue_credentials() May 15, 2024
@Todd-L-Miller
Copy link
Member Author

JaimeF OK'd this going in with only one of the methods tested, based on the way the code currently works.

@Todd-L-Miller
Copy link
Member Author

As is traditional, no release note for the version 2 bindings because they don't officially exist yet.

@Todd-L-Miller Todd-L-Miller marked this pull request as ready for review May 16, 2024 18:23
@Todd-L-Miller
Copy link
Member Author

This ended up being more code than I expected, so while it probably deserves its own ticket, it's instead part of the version 2 bindings parent ticket.

@ColeBollig
Copy link
Contributor

@Todd-L-Miller New test is failing

@Todd-L-Miller
Copy link
Member Author

The test depends on the Python module scitokens, which I'd assumed would be available (as a runtime dependency of a component of the HTCSS). I've asked TimT to add it to the containers.

@ColeBollig ColeBollig added the build-and-test Trigger an automatic Batlab build and test label May 17, 2024
@Todd-L-Miller
Copy link
Member Author

The test failures on Ubuntu 20 are caused by weird crypto nonsense on that platform:

05/17/24 17:58:17.162 (D_ALWAYS) WARNING: LOCAL_CREDMON_PRIVATE_KEY must use elipitcal curve cryptograph algorithm
05/17/24 17:58:17.162 (D_ALWAYS) WARNING: `scitokens-admin-create-key --pem-private` should be used with `--ec` option
05/17/24 17:58:17.162 (D_ALWAYS) WARNING: Errors are likely to occur when attempting to serialize SciTokens

...

05/17/24 19:02:53.351 (D_ERROR) Failure when attempting to serialize a SciToken, likely due to algorithm mismatch

related to using the auto-generated host cert. For now, I'll just disable the test on those two platforms.

@ColeBollig ColeBollig added build-and-test Trigger an automatic Batlab build and test and removed build-and-test Trigger an automatic Batlab build and test labels May 19, 2024
Copy link
Contributor

@ColeBollig ColeBollig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Todd-L-Miller Todd-L-Miller merged commit b7bdce9 into main May 20, 2024
1 check passed
@Todd-L-Miller Todd-L-Miller deleted the V23_8-HTCONDOR-2153_issue_credentials_for-branch branch May 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-and-test Trigger an automatic Batlab build and test
Projects
None yet
2 participants