Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: improve dev environment documentation #202

Merged
merged 3 commits into from Mar 26, 2020

Conversation

stsievert
Copy link
Contributor

What does this PR implement?
It improves the development environment documentation, by making where commands are run, and which commands are run.

It also shows the output in dr. This file is intended for developers; I presume they're okay seeing some output (and also I wanted to see how the job was progressing).

@stsievert stsievert changed the base branch from master to v0.6.0 March 26, 2020 15:45
Copy link
Contributor

@JoshKarpel JoshKarpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one place where I don't think you need to source particular script

docs/source/devs/env.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #202 into v0.6.0 will not change coverage by %.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           v0.6.0   #202   +/-   ##
=====================================
  Coverage      78%    78%           
=====================================
  Files          19     19           
  Lines        1963   1963           
  Branches      315    315           
=====================================
  Hits         1538   1538           
  Misses        359    359           
  Partials       66     66           

@JoshKarpel
Copy link
Contributor

The only test that failed is one I've had my eye on for being flaky, so I'm going to go ahead and merge.

@JoshKarpel JoshKarpel merged commit 6561752 into htcondor:v0.6.0 Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants