Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the error messages on upload failures. #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improvements to the error messages on upload failures. #78

wants to merge 1 commit into from

Conversation

bbockelm
Copy link

  • Capture the HTTP status code on failure (esp. for uploads) and add it to the error accumulator.
  • Use the error accumulator mechanism for uploads.
  • Ensure that fatal upload failures aren't labelled retryable.
  • When generating upload error messages, don't use the word "downloading"

@bbockelm
Improvements to the error messages on upload failures.
44e26f5 
- Capture the HTTP status code on failure (esp. for uploads) and
  add it to the error accumulator.
- Use the error accumulator mechanism for uploads.
- Ensure that fatal upload failures aren't labelled retryable.
- When generating upload error messages, don't use the word "downloading"
@bbockelm bbockelm requested a review from CohenQU June 12, 2023 00:48
@bbockelm
Copy link
Author

@CohenQU - ping on this PR review.

matyasselmeci
matyasselmeci approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@matyasselmeci matyasselmeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bbockelm
Copy link
Author

@jhiemstrawisc - is this in the Pelican v7.0.0 release?

@jhiemstrawisc
Copy link

It doesn't look like it, no. I'll cross reference this for the 7.1.0 release and assign myself a ticket to get this merged.

@jhiemstrawisc jhiemstrawisc mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasselmeci matyasselmeci matyasselmeci approved these changes

@CohenQU CohenQU Awaiting requested review from CohenQU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbockelm @jhiemstrawisc @matyasselmeci