Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a 'local credmon' mode #12

Merged
merged 8 commits into from Feb 8, 2019

Conversation

bbockelm
Copy link
Contributor

@bbockelm bbockelm commented Feb 8, 2019

The local credmon mode generates a SciToken signed by the credmon itself as opposed to calling out via OAuth.

Fixes #2

Copy link
Contributor

@jasoncpatton jasoncpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Can you add the scitokens package to the install requirements?

I will remove the nonessential abstract methods from the abstract credmon class, not sure why I thought those were all essential, the only non-internal call is scan_tokens().

@bbockelm
Copy link
Contributor Author

bbockelm commented Feb 8, 2019

@jasoncpatton - OK, I think all is now cleaned up. Please re-review.

Copy link
Contributor

@jasoncpatton jasoncpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbockelm bbockelm merged commit ab72537 into htcondor:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants