New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a 'local credmon' mode #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! Can you add the scitokens package to the install requirements?
I will remove the nonessential abstract methods from the abstract credmon class, not sure why I thought those were all essential, the only non-internal call is scan_tokens()
.
d9f587d
to
7539ff3
Compare
This provides a convenience function to allow a Python object to be serialized to JSON then moved into place in an atomic manner.
This allows a credmon with the appropriate private key to sign a token directly with no OAuth callouts needed.
7539ff3
to
f5949c9
Compare
@jasoncpatton - OK, I think all is now cleaned up. Please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The local credmon mode generates a SciToken signed by the credmon itself as opposed to calling out via OAuth.
Fixes #2