-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BacktrackingTM Removal #327
Comments
Similar/related #95 with removal of TP (BackTM depends on TP) |
this and the fact that the code is not being actively developed/used. The idea of having only one, universal implementation (for TM) is tempting, The timing is little unfortunate, as we've just merged the BackTM region PR. I'd be either for removing both BackTM and TP(Cells4), or for letting that code be until it breaks severely enough. Slightly in favor for the removal, but no strong opinion. |
I'm not so sure it's working because:
|
Cells4 appears to implement the temporal memory algorithm. It contains references to
I think we've reached a consensus. We all agree that BacktrackingTM & Cells4 should probably go away. Unless there are any objections? |
I do not agree. I don't think we should spend any more time on it ...i.e. don't put SDR's in it. But it does not hurt to remain. I propose that we leave it until it "gets in the way". I think it might be useful for comparisons. |
No, the BacktrackingTMRegion is new but Cells4 has been there for a long time as far as I can tell. |
Closing here and merging to #95 |
Pros/Cons comparison versus the regular Temporal Memory.
Pros:
Cons:
It has never been published in a peer reviewed journal. Details about how it works inside are hard to find. We, the implementers and maintainers of the code can't even explain what all of the options do. Specifically what are the following options for?
doPooling
segUpdateValidDuration: TODO: document
. Yes this todo note is in the docs & source code.anomalyMode
&inferenceMode
printColConfidence
what? how?pamLength. This is one of those bells or whistles. From the docs:
Also PAM is required, from the source:
NTA_ASSERT(pamLength > 0) << "This implementation must have pamLength > 0";
Confusing, has 26 arguments.
Unit tests for the current C++ implementation
In favor of Removal
The text was updated successfully, but these errors were encountered: