Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Region classes from dkeeney #54

Closed
3 tasks
breznak opened this issue Aug 9, 2018 · 5 comments
Closed
3 tasks

Merge Region classes from dkeeney #54

breznak opened this issue Aug 9, 2018 · 5 comments
Assignees

Comments

@breznak
Copy link
Member

breznak commented Aug 9, 2018

  • SPRegion
  • TMRegion
  • tests
@dkeeney
Copy link

dkeeney commented Jan 20, 2019

I think we did ok on this one. Lets close it.

@dkeeney dkeeney closed this as completed Jan 20, 2019
@breznak breznak added the high label Feb 1, 2019
@breznak
Copy link
Member Author

breznak commented Feb 1, 2019

Reopening and actually marking as a high priority.
We do not have the mentioned classes in this repo, although I know you've implemented them a long time ago.

This is needed for more complex NAPI support in c++, something mentioned recently and useful for many examples.

Please take a look when you are finished with your current stuff.

@breznak breznak reopened this Feb 1, 2019
@dkeeney
Copy link

dkeeney commented Feb 1, 2019

Ok, I will go find the C++ code for RegionTM and RegionSP and start a PR for each of them.

  • RegionSP was fairly complete.
  • RegionTM was setup to call BacktrackingTMCpp and is missing the "Shim" that maps the arguments to TemporalMemory. So there might be a little more porting from python to complete that class.

@breznak
Copy link
Member Author

breznak commented Feb 1, 2019

Ok, I will go find the C++ code for RegionTM and RegionSP and start a PR for each of them.

That'd be great 👍

Will we want bindings as a part of the PR, or separate? Or actually the Py Regions exist, so there will be no use for bindings?

@dkeeney
Copy link

dkeeney commented Mar 5, 2019

finished in multiple PRs mostly #247

@dkeeney dkeeney closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants