Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spatial Pooler Python Documentation #509

Merged
merged 1 commit into from Jun 13, 2019
Merged

Spatial Pooler Python Documentation #509

merged 1 commit into from Jun 13, 2019

Conversation

ctrl-z-9000-times
Copy link
Collaborator

  • Copied SpatialPooler documentation from C++ to python bindings
  • Removed SP.initialize, use __init__ method instead
  • Fixed encoder docs

@ctrl-z-9000-times
Spatial Pooler Python Documentation
81417a8 
- Copied SP's docs from C++ to python bindings
- Removed SP.initialize, use __init__ instead
- Fixed encoder docs
@ctrl-z-9000-times ctrl-z-9000-times self-assigned this Jun 13, 2019
breznak
breznak approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the docs changes 👍
For the __init__ shouldn't we override it by default to call cpp::initialize?

@ctrl-z-9000-times ctrl-z-9000-times merged commit 87c84f1 into master Jun 13, 2019
@ctrl-z-9000-times ctrl-z-9000-times deleted the sp-py-docs branch June 13, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breznak breznak breznak approved these changes

Assignees

@ctrl-z-9000-times ctrl-z-9000-times

Labels
documentation Python Binding SP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctrl-z-9000-times @breznak