-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic start with offset #84
Conversation
Yeah, we should keep The correct behavior here is if
|
2a5e8c3
to
d88cba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in tests pass
1317002
to
24fd753
Compare
ea42d06
to
4264340
Compare
4264340
to
4d03c1d
Compare
edf67d6
to
159e991
Compare
This adds a (was failing) test for starting a dynamically sized list in a position offset from the top of the scroll-container.
However, this causes the skip-list to need to deal with negative numbers. To handle this, I then changed the determination of
middleVisibleValue
to: