Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opacity should be applied to all layers #84

Open
kdzwinel opened this issue Apr 18, 2018 · 1 comment
Open

Opacity should be applied to all layers #84

kdzwinel opened this issue Apr 18, 2018 · 1 comment
Assignees

Comments

@kdzwinel
Copy link
Collaborator

Currently opacity is only set on the shape-group and not set on text, svg, etc. which is a bug.

While discussing this we also found out that we don't calculate opacity properly. 'opacity' property is non-cascading in CSS, but it's effect does "cascade" on children (e.g. <div opacity=.5><div opacity=.5></div> - inner div should have opacity of 0.25). In order to fix that we should collect all parent opacities and multiply them.

@kdzwinel
Copy link
Collaborator Author

It turns out to be a bit more work because we need to add opacity support to SVG and TextStyle objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants