-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to add space between link url and brackets #236
Comments
Hmm. There is a valid point here, when dealing with real-world systems. Existing formatter looks quite bad already from the amount of customizations. As a workaround, you can take it as a base for your custom formatter right now (see Readme section). I'll think about a nicer way to customize the link format compared to another boolean option. |
Thank you. That makes sense. I guess another solution would be adding spaces between urls and brackets by default. I do get clicks on links ending in ] quite often |
I think I will deprecate |
With version 8.1.0 you can now specify bracket strings for links and images: {
selectors: [
{ selector: 'a', options: { linkBrackets: ['[ ',' ]'] } },
{ selector: 'img', options: { linkBrackets: ['[ ',' ]'] } }
]
} |
@KillyMXI Curious as to why this is an array and not |
@webstech I haven't spent much time considering the options, honestly.
Thinking about it now, after implementing the new CLI (not public yet), every extra non-word characters you'd have to type in command line can become a source of issues as well. |
Problem to solve
Some browsers or email clients are interpreting the closing ] bracket of a link as part of the url
What works
You can remove brackets, but I'd rather have them
What is missing
There's no option to leave brackets on but add a space between them and the link
How the missing feature should be implemented
An option like noLinkBrackets
The text was updated successfully, but these errors were encountered: