Work even when 'fs' not available for require #164
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the node module 'fs' is not available, so instead of failing completely, this will help 'html-to-text' regress gracefully by changing the one dependent library function
fromFile
to callback with a specific failure, if called at runtime.Also, by using a string variable as an argument to
require
, it helps prevent webpack's static analysis from failing if it happens to try making a bundle in an fs-less environment.Since it seems many others were also having this problem, I'm raising the PR here instead of just creating another fork with the
fs
code removed.