Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

監訳完了から指摘箇所修正のプルリクについて #10

Closed
mitsuruog opened this issue Jan 3, 2014 · 2 comments
Closed

監訳完了から指摘箇所修正のプルリクについて #10

mitsuruog opened this issue Jan 3, 2014 · 2 comments

Comments

@mitsuruog
Copy link
Member

こちらに記載があると思いますが、認識正しいか確認させてください。

https://github.com/html5j-english/README/wiki/Review-and-Pull-Request-Work-Flow

監訳完了時は監訳依頼時のプルリクをクローズして、監訳の指摘箇所を修正したものを新たにプルリクする形でよろしいでしょうか？
@studiomohawk
Copy link
Member

はい。
某en.ja OSSと違うのですが、
Pull Requestを受け入れるのは監訳後に修正いただいたものとさせていただこうかと。

@mitsuruog
Copy link
Member Author

承知しました！

@mitsuruog mitsuruog mentioned this issue Jan 5, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@studiomohawk @mitsuruog