Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unittest.mock instead of mock #541

Closed
pgajdos opened this issue Mar 21, 2022 · 3 comments · Fixed by #574
Closed

use unittest.mock instead of mock #541

pgajdos opened this issue Mar 21, 2022 · 3 comments · Fixed by #574

Comments

@pgajdos
Copy link

pgajdos commented Mar 21, 2022

Could you please consider to use unittest.mock at least as fallback, when mock is not installed?
@hugovk
Copy link
Contributor

hugovk commented Apr 3, 2022

Please see PR #536 that drops support for EOL Python and replaces the mock library with the stdlib.

@hugovk hugovk mentioned this issue Apr 3, 2022
Closed
@pgajdos
Copy link
Author

pgajdos commented Apr 4, 2022

Thanks!

@pgajdos pgajdos closed this as completed Apr 4, 2022
eli-schwartz added a commit to eli-schwartz/html5lib-python that referenced this issue Oct 17, 2023
@eli-schwartz
tests: drop dependency on external mock module for newer python
5ec6e5e 
Starting python 3.3, this is in the stdlib.

Fixes html5lib#541
@eli-schwartz eli-schwartz mentioned this issue Oct 17, 2023
Merged
@eli-schwartz
Copy link
Contributor

Interesting that this ticket was closed without a PR merged to implement it. :)

ambv added a commit that referenced this issue Jan 10, 2024
@eli-schwartz @ambv
tests: drop dependency on external mock module for newer python (#574)
82c2599 
Fixes #541

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hugovk @pgajdos @eli-schwartz