Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing MathML tags for annotations. #183 #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fred-wang
Copy link

@willkg willkg added this to the 1.0 milestone Oct 3, 2017
@willkg
Copy link
Contributor

willkg commented Oct 31, 2017

The sanitizer is built to make sure the output is safe regardless of what the input was. So in order to approve adding these, I need to feel confident that these are safe to add.

There's this comment which you wrote that talks about the safety of adding these bits:

#181 (comment)

However, I don't know anything about MathML and can't evaluate that, so I can't approve this. We'll need someone who understands this to yay/nay it preferably with some proof. I'll hunt around and see if I can find someone I know.

@willkg
Copy link
Contributor

willkg commented Nov 6, 2017

I can't find anyone. I'm going to nix this from the 1.0 milestone.

@willkg willkg removed this from the 1.0 milestone Nov 6, 2017
@fred-wang
Copy link
Author

@willkg What's the plan on this? Did you ask @jruderman ?

@willkg
Copy link
Contributor

willkg commented Jun 5, 2018

@fred-wang I didn't find anyone, so I nixed it from the 1.0 milestone. After I got 1.0 out, I stepped off of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants