Use texture compression in ResourceManager::LoadTexture
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use compressed images during subsequent loads
htmlboss
commented
Jan 6, 2022
MP-APS/ResourceManager.cpp
Outdated
| in.read((char*)compressedData.get(), size); | ||
|
|
||
| glBindTexture(GL_TEXTURE_2D, textureID); | ||
| glCompressedTexImage2D(GL_TEXTURE_2D, 0, format, width, height, 0, size, compressedData.get()); |
There was a problem hiding this comment.
htmlboss
commented
Jan 6, 2022
| format = GL_RGBA; | ||
| break; | ||
| } | ||
| GLint compressed = GL_FALSE; |
There was a problem hiding this comment.
htmlboss
commented
Jan 6, 2022
| out.write((char*)(&desc.width), sizeof(CompressedImageDesc::width)); | ||
| out.write((char*)(&desc.height), sizeof(CompressedImageDesc::height)); | ||
| out.write((char*)(&desc.format), sizeof(CompressedImageDesc::format)); | ||
| out.write((char*)(desc.data.get()), desc.size); |
There was a problem hiding this comment.
Use c-style cast since reinterpret_case cannot cast away const and I'd rather not nest a const_cast in here since it's very verbose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was playing around with Valgrind to track down what I felt was excessive memory usage by the engine, which brought me to learn about on-the-fly texture compression offered by the OpenGL driver. Figured we should use that to reduce system memory usage, with the downside being we will have longer startup time as now the driver has to compress the images on the fly before uploading to the GPU.
Data/cache/textures/*.bin.Used the corresponding enums from Table 3 in https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glTexImage2D.xhtml
With the OOB PBR Sponza scene, here are the results:
Screenshots
Before
Compiled with
-gCompiled without
-gAfter
Compiled with
-gCompiled without
-g