Fix Default Styles for Radio input, Revert unmounting of conditional …

…display container.
htmlburger · Mar 10, 2023 · 409afd9 · 409afd9
1 parent 8c9cd54
commit 409afd9
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 12 deletions.
diff --git a/build/classic/core.css b/build/classic/core.css
@@ -2044,7 +2044,8 @@ span.flatpickr-weekday {
 }
 .cf-radio__input[type=checkbox]:checked:before {
   content: "";
-  background: var(--wp-admin-theme-color);
+  background-color: #3582c4;
+  background-color: var(--wp-admin-theme-color, #3582c4);
   border-radius: 50%;
   width: 0.5rem;
   height: 0.5rem;

diff --git a/build/classic/core.min.css b/build/classic/core.min.css
diff --git a/build/classic/metaboxes.js b/build/classic/metaboxes.js
diff --git a/build/classic/metaboxes.min.js b/build/classic/metaboxes.min.js
diff --git a/build/gutenberg/core.css b/build/gutenberg/core.css
@@ -2044,7 +2044,8 @@ span.flatpickr-weekday {
 }
 .cf-radio__input[type=checkbox]:checked:before {
   content: "";
-  background: var(--wp-admin-theme-color);
+  background-color: #3582c4;
+  background-color: var(--wp-admin-theme-color, #3582c4);
   border-radius: 50%;
   width: 0.5rem;
   height: 0.5rem;

diff --git a/build/gutenberg/core.min.css b/build/gutenberg/core.min.css
diff --git a/build/gutenberg/metaboxes.js b/build/gutenberg/metaboxes.js
diff --git a/build/gutenberg/metaboxes.min.js b/build/gutenberg/metaboxes.min.js
diff --git a/packages/core/fields/radio/style.scss b/packages/core/fields/radio/style.scss
@@ -56,7 +56,7 @@
 
 	&[type="checkbox"]:checked:before {
 		content: "";
-		background: var(--wp-admin-theme-color);
+		background-color: var(--wp-admin-theme-color, #3582c4);
 		border-radius: 50%;
 		width: 0.5rem;
 		height: 0.5rem;

diff --git a/packages/metaboxes/monitors/conditional-display/handler/index.js b/packages/metaboxes/monitors/conditional-display/handler/index.js
@@ -114,7 +114,7 @@ export default function handler( { containers, context } ) {
 					// due to https://github.com/facebook/react/issues/13690.
 					// TODO: Conditionally render the fields in the container, this way
 					// we can move away from mount/unmount cycles.
-					//containerNode._reactRootContainer.unmount(); // -- causes a memory leak bug
+					containerNode._reactRootContainer.unmount();
 				}
 			}
 		} );