fix rule: attr-value-double-quotes

htmlhint · Mar 23, 2013 · 88d00ab · 88d00ab
1 parent 6088fb3
commit 88d00ab
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/coverage.html b/coverage.html
diff --git a/lib/htmlhint.js b/lib/htmlhint.js
diff --git a/src/rules/attr-value-double-quotes.js b/src/rules/attr-value-double-quotes.js
@@ -13,7 +13,7 @@ HTMLHint.addRule({
                 col = event.col + event.tagName.length + 1;
             for(var i=0, l=attrs.length;i<l;i++){
                 attr = attrs[i];
-                if(attr.quote !== '' && attr.quote !== '"'){
+                if(attr.quote !== '"' && (attr.value !== '' || (attr.value === attr.quote === ''))){
                     reporter.error('The value of attribute [ '+attr.name+' ] must closed by double quotes.', event.line, col + attr.index, self, attr.raw);
                 }
             }

diff --git a/test/rules/attr-value-double-quotes.spec.js b/test/rules/attr-value-double-quotes.spec.js
@@ -10,16 +10,19 @@ var HTMLHint  = require("../../index").HTMLHint;
 describe('Rules: attr-value-double-quotes', function(){
 
     it('Attribute value closed by single quotes should result in an error', function(){
-        var code = '<a href=\'abc\'>';
+        var code = '<a href=\'abc\' title=abc>';
         var messages = HTMLHint.verify(code, {'attr-value-double-quotes': true});
-        expect(messages.length).to.be(1);
+        expect(messages.length).to.be(2);
         expect(messages[0].rule.id).to.be('attr-value-double-quotes');
         expect(messages[0].line).to.be(1);
         expect(messages[0].col).to.be(3);
+        expect(messages[1].rule.id).to.be('attr-value-double-quotes');
+        expect(messages[1].line).to.be(1);
+        expect(messages[1].col).to.be(14);
     });
 
     it('Attribute value no closed should not result in an error', function(){
-        var code = '<a href=abc>';
+        var code = '<input type="button" disabled>';
         var messages = HTMLHint.verify(code, {'attr-value-double-quotes': true});
         expect(messages.length).to.be(0);
     });