Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for illumos/Solaris platforms #1371

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fixes for illumos/Solaris platforms #1371

merged 1 commit into from
Jan 11, 2024

Conversation

hadfl
Copy link
Contributor

@hadfl hadfl commented Jan 11, 2024

This fixes build errors/warnings on illumos that were introduced in the most recent htop release (3.3.0), as well as a segmentation fault due to a non-allocated kstat structure.

Copy link
Member

@fasterit fasterit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that 3.3.0 is broken on Solaris and builds & runs after these fixes.
Not reviewed for correctness.

@BenBE BenBE added bug 🐛 Something isn't working Solaris Solaris, Illumos, OmniOS, OpenIndiana labels Jan 11, 2024
@BenBE BenBE added this to the 3.4.0 milestone Jan 11, 2024
Copy link
Member

@BenBE BenBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes to make sense in the context of the recent refactorings of internal structures. LGTM.

@BenBE BenBE merged commit 046b6ce into htop-dev:main Jan 11, 2024
12 checks passed
@hadfl hadfl deleted the illumos branch January 11, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Solaris Solaris, Illumos, OmniOS, OpenIndiana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants