-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darwin/Platform.c: do not include non-existing headers which break build #1381
Conversation
4d0b37d
to
e1739f7
Compare
@BenBE Thank you, I have dropped AvailabilityMacros header from Platform.h now, the fallback now is in Platform.c. (Perhaps there is little point to make a specific check here, we know that prior to 10.9 there is no folder for types in /usr/include/sys, SDKs are public, and the files are specifically for Darwin, no surprises here.) |
@barracuda156 htop coding style prefers not to have a version number check in order to determine whether a header is available. You may mention the version number in code comments, but we would like the header availability be checked in |
@Explorer09 Ok, let me make recommended changes, confirm that such solution will actually work and then rebase the PR. |
e1739f7
to
17acf3c
Compare
@Explorer09 Could you please review? |
17acf3c
to
a5dc0d0
Compare
Unbreak builds on macOS versions where _mach_port_t.h does not exist. mach/port.h exists on every macOS and has needed defines.
a5dc0d0
to
3d0d96f
Compare
@Explorer09 @BenBE I have switched to a simpler version which just replaces the included header with the universally supported one, as suggested by @ryandesign above. |
Commit ed7eac5 unconditionally includes a header which is not present on earlier macOS. This unnecessarily breaks the build. Use includes correctly.