It is inappropriate to use the 'fd' name for 'FILE*' variables.
POSIX file descriptiors are of type 'int' and are distinguished from
ISO C stream pointers (type 'FILE*').

Rename these variables to 'fp', which is a preferred naming in POSIX.
(Note that ISO C preferred the 'stream' name for the variables.)

No code changes.

Deprecate the use of 'st' and other names. The 'sb' name is often seen
in example codes in Linux man pages. (The 'statbuf' name is sometimes
also used but I choose 'sb' name because it's shorter.)

No code changes.

Only happens with LTO, -fanalyzer, and -fsanitize=address,leak

The use of CUSTOM_METERMODE value in meter default mode was a bad
design. There are no meter that really has a "custom" mode to work with
and currently that value serves as a useless placeholder that hides the
real default mode for a meter.

Replace CUSTOM_METERMODE in `defaultMode` of all meters with the real
intended default modes. Currently only CPU meters and MemorySwapMeter
used this, and their real defaults are BAR_METERMODE.

In Meter_setMode(), remove the special treatment of `defaultMode ==
CUSTOM_METERMODE`, Meter_setMode() still calls the `updateMode` function
for custom treatment when it's present for a meter class.

As CUSTOM_METERMODE is obsolete from `defaultMode`, the init functions
of CPU meters and MemorySwapMeter need to be adjusted to avoid
incomplete initialization (Meter.draw function bring NULL).

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

Let the respective `MeterClass.updateMode` functions initialize the
meter mode instead. The `updateMode` function is always called after the
`MeterClass.init` function by `Meter_new()`.

This not only simplifies the init functions of meter subclasses, but
avoids the use of the global `Meter_modes` array when it's unnecessary.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

Meter mode ID 0 will now be reserved.

The Meter objects have their own 'h' properties.
Avoid access to the `Meter_modes` array.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

The Meter objects have their own 'h' properties.
Avoid access to the `Meter_modes` array.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

This section reordering is a prerequisite to privatizing the
`Meter_modes` array.

All client codes that access this global `Meter_modes` array have been
replaced in previous commits, thus it's no longer necessary to keep
this internal information (draw functions, default heights, etc.)
public. It was also a bad idea when the client codes need to avoid
accessing `Meter_modes[0]` (which is reserved and contains null
information) by themselves.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

This is a prerequisite to using MeterModeId type in more headers, to
avoid header dependency hell.

All uses of meter drawing "mode" numbers now have the type
`MeterModeId`, including the uses in structures and arrays.
`MeterModeId` is defined as `unsigned int`, as (currently) it doesn't
save any code size by defining it to any smaller type.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

Inspired by: hishamhm/htop#848

Closes: htop-dev#542

`__STDC_VERSION__` will be defined as 202311L for C23.

Assume the CGROUP, CCGROUP, CONTAINER and SECATTR field value may
contain non-ASCII characters and use RichString_appendWide() to convert
the strings.

Patch suggested by Christian Göttsche (@cgzones)

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

The warning message is
"array subscript has type 'char' [-Wchar-subscripts]"

Fix this by casting to 'unsigned char' before passing any character to a
`<ctype.h>` function.

Also add an assertion to RichString_writeFromAscii() to ensure the
characters in the string are all in ASCII range.

Signed-off-by: Kang-Che Sung <explorer09@gmail.com>

Since \n is used internally by htop to split command lines, replace \n
with \r in command lines to not display them as space.

Merging the command string will not work, but newlines in commands
should be rather the exception.

The arguments to our mbrtowc(3) wrapper should not alias, since they
also must not for mbrtowc(3).

Might help some compilers optimizing the code.

When parsing an essential pid entry file like 'status' fails, we treat
the process as a short-lived one and skip adding it into the process
table.

This should be done before the process is added, as the goto label used
for error handling can free the process structure, thus causing an
use-after-free scenario.

Fixes: 22d25db ("Linux: detect container process by different PID namespace")
Closes: htop-dev#1455