Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not scan new processes for deleted libs #988

Merged
merged 1 commit into from May 26, 2022
Merged

Do not scan new processes for deleted libs #988

merged 1 commit into from May 26, 2022

Conversation

cgzones
Copy link
Member

@cgzones cgzones commented Apr 30, 2022

No description provided.

BenBE
BenBE requested changes Apr 30, 2022
View reviewed changes
linux/LinuxProcessList.c Show resolved Hide resolved
linux/LinuxProcessList.c Outdated Show resolved Hide resolved
@BenBE BenBE added this to the 3.2.1 milestone Apr 30, 2022
@BenBE BenBE added the Linux 🐧 Linux related issues label Apr 30, 2022
@BenBE
Copy link
Member

BenBE commented Apr 30, 2022

Also the scanning of the libraries also calculates the M_LRS (library size) column, which is left blank after this change in the first few iterations.

@cgzones
Copy link
Member Author

cgzones commented Apr 30, 2022

If the M_LRS column is enabled, PROCESS_FLAG_LINUX_LRS_FIX is set and this addition does not interfere with the condition ss->flags & PROCESS_FLAG_LINUX_LRS_FIX. It might only be empty for new processes when the column gets enabled until the next scan cycle.

@BenBE
Copy link
Member

BenBE commented Apr 30, 2022

If the M_LRS column is enabled, PROCESS_FLAG_LINUX_LRS_FIX is set and this addition does not interfere with the condition ss->flags & PROCESS_FLAG_LINUX_LRS_FIX. It might only be empty for new processes when the column gets enabled until the next scan cycle.

Misread that || as &&. That's where the confusion came from.

@BenBE BenBE merged commit 0e29174 into htop-dev:main May 26, 2022
@cgzones cgzones deleted the not_new branch May 26, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenBE BenBE BenBE approved these changes

Assignees
No one assigned
Labels
Linux 🐧 Linux related issues
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgzones @BenBE