Bugfix: Allow empty Reason-Phrase #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Decoder class unexpectedly fails to decode a response starting with
"HTTP/1.1 200 \r\n"
while the following initial line is accepted even if, strictly speaking,
against the RFC 2616:
"HTTP/1.1 200\r\n"
(I think both should be accepted by HTTP Kit.)
Use an `offset` argument with `HttpUtils/findEndOfString` to make it behave consistently with the rest of the `find*` string methods.
|
Once more, if it wasn't clear from the description, let me point out that the RFC 2616 actually requires the space after the |
|
Thanks! Will look into this once time is allowed. Now in a busy project with a strict deadline. |
|
FYI, this bug is getting more important as Facebook is apparently rolling out its new server versions that omit the $ curl -I https://www.facebook.com
HTTP/1.1 200
Cache-Control: private, no-cache, no-store, must-revalidate
... |
shenfeng
added a commit
that referenced
this pull request
Mar 16, 2014
Bugfix: Allow empty Reason-Phrase
|
Sorry for respond late. |
|
Is there a release planned relatively quickly? I am relying on http-kit to interact with the facebook api quite heavily and this hit us badly. Thanks |
|
Just push [http-kit "2.1.18"]to clojars. With other few bug fixes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code in master, the condition in https://github.com/http-kit/http-kit/blob/master/src/java/org/httpkit/client/Decoder.java#L55-L58 still fails to work for a correctly behaving HTTP server that just happens to omit the
Reason-Phrasereturning aStatus-Linewith a space following theStatus-Code, e.g."HTTP/1.1 200 ".This pull request fixes
HttpUtils/findEndOfStringto handle this case correctly, and adds a set of unit tests that check the behavior oforg.httpkit.client.Decoder.