Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not force accept encoding #472

Conversation

MarcoNicolodi
Copy link
Contributor

@MarcoNicolodi MarcoNicolodi commented Aug 13, 2021

Solves #471

This to pay attention to:

  • Is RequestConfig the best class to pass this option?
  • Is disableAutoCompression a good name?

@MarcoNicolodi
Copy link
Contributor Author

Hello @ptaoussanis

Do you have an estimate of when you will be able to review/release this, so we can plan on our side here?

Thanks.

@ptaoussanis
Copy link
Member

@MarcoNicolodi Hi Marco, thanks for the PR!

I can aim to try review around next weekend (4 September).

Suggesting one change so long:

  • Instead of disable-auto-compression? (default false), have you considered auto-compression? (default true)? Think it might be preferable to avoid negative flags, which can be difficult to parse and lead to double negatives, etc.

Thanks

@ptaoussanis
Copy link
Member

Merging manually now, sorry about the big delay. Thanks a lot for the report and PR Marco!
Will come back shortly with a new release.

@ptaoussanis
Copy link
Member

[http-kit "2.6.0-alpha1"] now on Clojars, release info here.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants