Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404.html served with 200 status code #101

Closed
OliverJAsh opened this issue Oct 21, 2014 · 5 comments
Closed

404.html served with 200 status code #101

OliverJAsh opened this issue Oct 21, 2014 · 5 comments

Comments

@OliverJAsh
Copy link

I have a 404.html file which is being used by the server when a 404 occurs. However, the server sends a response status code of 200, not 404.

@OliverJAsh
Copy link
Author

Is this supposed to happen when there is a 404.html file?

@indexzero
Copy link
Collaborator

No, that shouldn't happen. Could you make a PR for this? It might need to be on ecstatic, but I'm not 100% sure.

@OliverJAsh
Copy link
Author

See jfhbrook/node-ecstatic#122.

@OliverJAsh
Copy link
Author

Fixed in jfhbrook/node-ecstatic#122

@OliverJAsh
Copy link
Author

Can we update the dep to v0.5.6 and release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants