Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --tls option and have --ssl be an alias for it #588

Closed
thornjad opened this issue Dec 18, 2019 · 4 comments · Fixed by #747
Closed

Make --tls option and have --ssl be an alias for it #588

thornjad opened this issue Dec 18, 2019 · 4 comments · Fixed by #747

Comments

@thornjad
Copy link
Member

A small pet peeve of mine is that the --ssl option enables TLS, not SSL. I accept that the tech world uses these related but different terms interchangeably, but I'd rather be more correct by default.

To do:

  1. Replace the existing --ssl option with --tls.
    a. Note that this enables "TLS/SSL" in the documentation so it doesn't confuse people.
    b. The short option -S could stay the same, having it stand for "Secure".
  2. Add back the --ssl option as an alias for --tls.
    a. Note in the documentation that it's an alias
    b. In the code, if ssl is specified, translate it directly into the tls option.
    c. If for some reason the user specifies both options, like --tls --no-ssl, consider --tls to be the authoritative option (i.e. allow the tls option to override ssl).
@ankurkaushal
Copy link

@thornjad: Is this issue still relevant? I have been meaning to get back into OSS & this seemed like an easy win. :)

@thornjad
Copy link
Member Author

Yeah, this is still outstanding, go for it!

@dalgleish dalgleish mentioned this issue Jul 18, 2020
2 tasks
@ankurkaushal
Copy link

@thornjad: Looks like @dalgleish already beat me to it. :)

@github-actions
Copy link

This issue has been inactive for 180 days

@github-actions github-actions bot added the stale label Aug 19, 2021
@thornjad thornjad added Hacktoberfest Attract attention to this issue and removed stale labels Sep 30, 2021
@thornjad thornjad removed good first issue Hacktoberfest Attract attention to this issue labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants