close socket if upstream request fails

adds socket.end() to on('error') handlers for proxyReq and proxySocket
http-party · Oct 1, 2014 · e894f63 · e894f63
1 parent 43c6f0c
commit e894f63
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/http-proxy/passes/ws-incoming.js b/lib/http-proxy/passes/ws-incoming.js
@@ -124,6 +124,7 @@ var passes = exports;
       } else {
         server.emit('error', err, req, socket);
       }
+      socket.end();
     }
   }
 

diff --git a/test/lib-http-proxy-test.js b/test/lib-http-proxy-test.js
@@ -280,17 +280,24 @@ describe('lib/http-proxy.js', function() {
       client.on('open', function () {
         client.send('hello there');
       });
+
+      var count = 0;
+      maybe_done = function () {
+          count += 1;
+          if (count === 2) done();
+      }
 
       client.on('error', function (err) {
         expect(err).to.be.an(Error);
         expect(err.code).to.be('ECONNRESET');
+        maybe_done();
       });
 
       proxy.on('error', function (err) {
         expect(err).to.be.an(Error);
         expect(err.code).to.be('ECONNREFUSED');
         proxyServer.close();
-        done();
+        maybe_done();
       });
     });