Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node6 support, add node12 to build #1397

Merged
merged 1 commit into from May 17, 2020
Merged

Remove node6 support, add node12 to build #1397

merged 1 commit into from May 17, 2020

Conversation

jsmylnycky
Copy link
Contributor

@jsmylnycky jsmylnycky commented Nov 4, 2019

No description provided.

@LiranBri
Copy link

LiranBri commented Jan 1, 2020

+1

@jimmyandrade
Copy link

jimmyandrade commented May 16, 2020

@jsmylnycky maybe we could drop support to Node 8 also, what do you think?

@@ -1,9 +1,9 @@
sudo: false
language: node_js
node_js:
- "6"
- "8"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove support to Node 8 also

@@ -35,7 +35,7 @@
"version": "auto-changelog -p && git add CHANGELOG.md"
},
"engines": {
"node": ">=6.0.0"
"node": ">=8.0.0"
Copy link

@jimmyandrade jimmyandrade May 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to change it to `>=10.0.0"

@jcrugzz jcrugzz merged commit dba3966 into master May 17, 2020
@jcrugzz jcrugzz deleted the hotfix/node8plus branch May 17, 2020
@mewelling
Copy link

mewelling commented May 20, 2020

just curious why this wasn't a major semver change? Seems to me that dropping support for two major versions of node would be considered a breaking change.

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants