Remove node6 support, add node12 to build #1397
Merged
Conversation
|
+1 |
|
@jsmylnycky maybe we could drop support to Node 8 also, what do you think? |
| @@ -1,9 +1,9 @@ | |||
| sudo: false | |||
| language: node_js | |||
| node_js: | |||
| - "6" | |||
| - "8" | |||
jimmyandrade
May 16, 2020
I'd remove support to Node 8 also
I'd remove support to Node 8 also
| @@ -35,7 +35,7 @@ | |||
| "version": "auto-changelog -p && git add CHANGELOG.md" | |||
| }, | |||
| "engines": { | |||
| "node": ">=6.0.0" | |||
| "node": ">=8.0.0" | |||
jimmyandrade
May 16, 2020
•
I'd suggest to change it to `>=10.0.0"
I'd suggest to change it to `>=10.0.0"
|
just curious why this wasn't a major semver change? Seems to me that dropping support for two major versions of node would be considered a breaking change. |
This was referenced Sep 5, 2020
This was referenced Sep 5, 2020
This was referenced Sep 7, 2020
This was referenced Sep 7, 2020
This was referenced Sep 8, 2020
This was referenced Sep 10, 2020
This was referenced Sep 11, 2020
This was referenced Sep 11, 2020
Merged
This was referenced Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.