Fix problem with req.url not being not properly replaced. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What the... there's something added onto the end of a line! Let me fix that =P |
|
There we go =D (I did run tests on this btw, so I probably typed into the wrong window while committing.) |
|
Please wait before merging this pull request. I need to add tests and fix a few more cases based on other people's pull requests. |
|
There we go, now it can be pulled in. =D |
|
Any news on this pull request? |
|
Hey @coderarity do you know if this is this going in or not? |
|
Not yet. On Saturday, June 2, 2012 at 7:06 AM, Anton Whalley wrote:
|
|
Thanks. Any clue what is blocking release? |
coderarity
added a commit
that referenced
this pull request
Jun 5, 2012
Fix problem with req.url not being not properly replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #215. It changes the method to use url.parse (because it's easier to read, that old stuff took me a while to wrap my head around), and fixes it by replacing the path's part of the URL with the target's part of the URL, instead of just getting rid of it completely.