Emit http-proxy:outgoing:ws:error for errors after the upgrade header. #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Node http client (at least in 0.10.x) removes the socket error handler (which forwards errors from socket to request) before invoking 'upgrade'. So we need to put our error handler back on it if we don't want errors (eg ECONNRESET/EPIPE) talking to the server to throw.
|
i am in the process of refactoring how errors are handled (dropping wildcards among other things), but i'll make sure to include this... thanks! :D |
yawnt
added a commit
that referenced
this pull request
Nov 7, 2013
|
added, sorry for the late fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node http client (at least in 0.10.x) removes the socket error handler
(which forwards errors from socket to request) before invoking 'upgrade'. So we
need to put our error handler back on it if we don't want errors (eg
ECONNRESET/EPIPE) talking to the server to throw.
See https://gist.github.com/glasser/6893545 for an example script showing why this is necessary.