Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version mismatch on mkdirp between package.json and package-lock.json #108

Closed
LostInBrittany opened this issue Jul 20, 2020 · 1 comment · May be fixed by WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition#258

Comments

@LostInBrittany
Copy link
Contributor

Hi!

I see that in PR #101 you bumped-up the version of mkdirp to 0.5.5 which in turn updates minimist to 1.2.5
which addresses https://www.npmjs.com/advisories/1179

Problem is that this PR only updated package-lock.json and not package.json that remains at 0.5.1. As package.json still depends on mkdirp 0.5.1, when we get node-portfinder as a dependency, we still get an old version of minimalist.

@eriktrom
Copy link
Member

whoa, thankyou @LostInBrittany - sorry for the delay here, shipping update immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants